Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable new dicts only on edited profile #752

Merged

Conversation

StefanVukovic99
Copy link
Member

Resolves #738

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner March 1, 2024 14:09
Copy link

codspeed-hq bot commented Mar 1, 2024

CodSpeed Performance Report

Merging #752 will improve performances by 47.13%

Comparing StefanVukovic99:new-dicts-only-one-profile (67f4939) with master (e47a0f4)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark master StefanVukovic99:new-dicts-only-one-profile Change
transformations (n=57) 54.7 ms 37.2 ms +47.13%

Copy link

github-actions bot commented Mar 1, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@Casheeew Casheeew added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Mar 2, 2024
@toasted-nutbread
Copy link

I think this is fine, but maybe there might be some utility in having an option during import to specify whether it's default enabled for the current profile or all profiles.

@djahandarie djahandarie added this pull request to the merge queue Mar 3, 2024
Merged via the queue into themoeway:master with commit 202949c Mar 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable new dictionaries only on current profile
4 participants